admin/OpenFin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: always GROUP BY me.id in market_events list query

Browse Source 
The LEFT JOIN on instrument_impacts (added for the evaluated subquery)
generates N rows per event when the event has N impacts. GROUP BY was
only applied when the instrument filter was active — now it's always on.
Fixes: total=2 but list shows 6+ duplicates.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
OpenSquared
2026-06-25 21:53:14 +02:00
parent 332d5ad743
commit acab69b65c
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
backend/routers/market_events.py
View File

@@ -168,8 +168,9 @@ def list_events(
sort_col = "me.impact_score" sort_col = "me.impact_score"
order_sql = f"ORDER BY {sort_col} {'DESC' if sort_dir == 'desc' else 'ASC'}" order_sql = f"ORDER BY {sort_col} {'DESC' if sort_dir == 'desc' else 'ASC'}"
# When joining with instrument_impacts an event can appear multiple times — use GROUP BY # Always GROUP BY — the LEFT JOIN on instrument_impacts creates duplicate rows
group_sql = "GROUP BY me.id" if instrument else "" # when an event has multiple impacts (one row per impact without GROUP BY)
group_sql = "GROUP BY me.id"
# Extra columns: evaluated flag + optional instrument score # Extra columns: evaluated flag + optional instrument score
evaluated_col = ( evaluated_col = (