From bdfc7f22e0d65102b75affb0ebdb726bd2be0117 Mon Sep 17 00:00:00 2001
From: "AzureAD\\SylvainDUVERNAY" <s.duvernay@singa-associates.com>
Date: Mon, 25 May 2026 11:37:47 +0200
Subject: [PATCH] Remove fx fields from Facility; fix facility_limit tree and
 parent field

- Remove fx_feeder and fx_haircut_pct fields from Facility model and form view
- Add field_childs to facility_limit tree view for hierarchical display
- Set parent field as readonly in facility_limit form

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 modules/trade_finance/facility.py                  | 4 ----
 modules/trade_finance/facility.xml                 | 1 +
 modules/trade_finance/view/facility_form.xml       | 4 ----
 modules/trade_finance/view/facility_limit_form.xml | 2 +-
 4 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/modules/trade_finance/facility.py b/modules/trade_finance/facility.py
index 036faf7..33b3853 100644
--- a/modules/trade_finance/facility.py
+++ b/modules/trade_finance/facility.py
@@ -91,10 +91,6 @@ class Facility(ModelSQL, ModelView):
 
     currency = fields.Many2One('currency.currency', 'Facility Currency',
         required=True, ondelete='RESTRICT')
-    fx_feeder = fields.Many2One('trade_finance.fx_feeder', 'FX Rate Feeder',
-        ondelete='RESTRICT')
-    fx_haircut_pct = fields.Numeric('FX Haircut (%)', digits=(16, 2))
-
     is_tpa = fields.Boolean('TPA',
         help='Third Party Account — broker managed structure')
     broker = fields.Many2One('party.party', 'Broker',
diff --git a/modules/trade_finance/facility.xml b/modules/trade_finance/facility.xml
index 7b32fd4..5fa523f 100644
--- a/modules/trade_finance/facility.xml
+++ b/modules/trade_finance/facility.xml
@@ -206,6 +206,7 @@
         <field name="type">tree</field>
         <field name="priority" eval="10"/>
         <field name="name">facility_limit_tree</field>
+        <field name="field_childs">children</field>
     </record>
     <record model="ir.ui.view" id="facility_limit_view_form">
         <field name="model">trade_finance.facility_limit</field>
diff --git a/modules/trade_finance/view/facility_form.xml b/modules/trade_finance/view/facility_form.xml
index b2e296a..f123b49 100644
--- a/modules/trade_finance/view/facility_form.xml
+++ b/modules/trade_finance/view/facility_form.xml
@@ -10,10 +10,6 @@
         <field name="commitment_status"/>
         <label name="currency"/>
         <field name="currency"/>
-        <label name="fx_feeder"/>
-        <field name="fx_feeder"/>
-        <label name="fx_haircut_pct"/>
-        <field name="fx_haircut_pct"/>
         <newline/>
         <label name="date_from"/>
         <field name="date_from"/>
diff --git a/modules/trade_finance/view/facility_limit_form.xml b/modules/trade_finance/view/facility_limit_form.xml
index 5208e2e..ee9eb49 100644
--- a/modules/trade_finance/view/facility_limit_form.xml
+++ b/modules/trade_finance/view/facility_limit_form.xml
@@ -20,7 +20,7 @@
         <field name="sequence"/>
         <newline/>
         <label name="parent"/>
-        <field name="parent" colspan="3"/>
+        <field name="parent" colspan="3" readonly="1"/>
         <label name="facility"/>
         <field name="facility" colspan="3"/>
         <label name="notes"/>