modules/purchase_trade/stock.py

@@ -856,7 +856,7 @@ class ShipmentIn(metaclass=PoolMeta):
                 #update line valuation
                 Pnl = Pool().get('valuation.valuation')
                 for lot in lots:
-                    Pnl.generate(lot.line)
+                    Pnl.generate(lot.line if lot.line else lot.sale_line)
             if sh.sof:
                 for sof in sh.sof:
                     if sof.chart:

modules/purchase_trade/valuation.py

@@ -331,8 +331,6 @@ class ValuationBase(ModelSQL):
         Date = Pool().get('ir.date')
         Valuation = Pool().get('valuation.valuation')
         ValuationLine = Pool().get('valuation.valuation.line')
-        if not line:
-            pass
         Valuation.delete(Valuation.search([
             ('line', '=', line.id),
             ('date', '=', Date.today()),